Skip to content

DNM: sd-card crutches (IDFGH-16599) #17712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DNM: sd-card crutches (IDFGH-16599) #17712

wants to merge 1 commit into from
+7 −1

Conversation

@pavlohamov
Copy link
Contributor

@pavlohamov pavlohamov commented Oct 7, 2025

do not merge it. relates to #15450

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "DNM: sd-card crutches":
    • summary looks too short
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello pavlohamov, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 168afc7

cursor[bot]
cursor bot reviewed Oct 7, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

components/sdmmc/sdmmc_init.c
* corrupts the new CMD frame (seen as CRC_ON_OFF fail). */
if (card->is_mem) {
SDMMC_INIT_STEP(always, sdmmc_send_cmd_go_idle_state);
}
Copy link

@cursor cursor bot Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: CMD0 Workaround Inconsistency Affects Memory Cards

The CMD0 workaround for CMD5 response delay corruption is applied only to memory cards (card->is_mem) and only when SDIO support is enabled. This means memory cards may not receive the fix if SDIO support is disabled, potentially causing CRC errors. The card->is_mem condition also seems inconsistent with the comment's description of the issue occurring "especially after CMD5," which is an SDIO-related command.

Fix in Cursor Fix in Web

@github-actions github-actions bot changed the title DNM: sd-card crutches DNM: sd-card crutches (IDFGH-16599) Oct 7, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

@pacucha42 pacucha42

Labels

Status: Opened Issue is new

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavlohamov @pacucha42 @espressif-bot